Bug 34411

Summary:

debug-safari doesn't pass --debug option to gdb-safari on MacOSX

Product:

WebKit

Reporter:

Shinichiro Hamaji <hamaji>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cjerdonek, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch v1	none
Patch v2	none

Shinichiro Hamaji

Reported 2010-02-01 00:20:22 PST

Because determinePassedConfiguration modifies @ARGV.

Attachments
Patch v1 (1.38 KB, patch) 2010-02-01 00:21 PST, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Patch v2 (1.09 KB, patch) 2010-02-17 21:14 PST, Shinichiro Hamaji	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Shinichiro Hamaji

Comment 1 2010-02-01 00:21:01 PST

Created attachment 47818 [details] Patch v1

Eric Seidel (no email)

Comment 2 2010-02-01 15:59:02 PST

This seems like a systemic problem with our perl code.

Eric Seidel (no email)

Comment 3 2010-02-17 15:43:17 PST

Comment on attachment 47818 [details] Patch v1 Doesn't webkitdirs.pm already have a function to return args like this? It must. How does run-webkit-tests --debug know to call build-dumprendertree with --debug otherwise?

Shinichiro Hamaji

Comment 4 2010-02-17 21:14:31 PST

Created attachment 48967 [details] Patch v2

Shinichiro Hamaji

Comment 5 2010-02-17 21:15:01 PST

True. Thanks for the nice suggestion!

Adam Barth

Comment 6 2010-02-18 00:10:21 PST

Comment on attachment 48967 [details] Patch v2 LGTM. I'm not an expert on our perl code, however.

Shinichiro Hamaji

Comment 7 2010-02-18 01:17:56 PST

Comment on attachment 48967 [details] Patch v2 Clearing flags on attachment: 48967 Committed r54947: <http://trac.webkit.org/changeset/54947>

Shinichiro Hamaji

Comment 8 2010-02-18 01:18:04 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.