Bug 34348

Summary: Windows has out of date virtual function in GraphicsLayer (setContentsToVideo is now setContentsToMedia)
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: MediaAssignee: Chris Marrin <cmarrin>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
eric: review-
replacement patch fixing LayoutTests
none
Replacement patch with more description of what changed in each file simon.fraser: review+

Chris Marrin
Reported 2010-01-29 14:43:04 PST
Simon recently changed the virtual function name in GraphicsLayer from setContentsToVideo to setContentsToMedia. The name needs to be updated in the Windows build
Attachments
Patch (6.14 KB, patch)
2010-01-29 17:53 PST, Chris Marrin 		eric: review-
DetailsFormatted DiffDiff
replacement patch fixing LayoutTests (6.86 KB, patch)
2010-02-05 15:50 PST, Chris Marrin 		no flags
DetailsFormatted DiffDiff
Replacement patch with more description of what changed in each file (7.18 KB, patch)
2010-02-05 16:31 PST, Chris Marrin 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2010-01-29 17:53:55 PST
Created attachment 47751 [details] Patch
Brian Weinstein
Comment 2 2010-01-31 00:42:16 PST
Chris, I'm worried this patch broke a bunch of tests: http://build.webkit.org/results/Windows%20Release%20(Tests)/r54108%20(8573)/results.html If you look at some of the results in the failing media tests - for example: http://build.webkit.org/results/Windows%20Release%20(Tests)/r54108%20(8573)/media/controls-styling-pretty-diff.html They seem to be failing due to layer issues, and these failures started between r54093 and r54095, so I think this r54095 is the culprit.
Eric Carlson
Comment 3 2010-01-31 20:57:11 PST
Reverted the changes for now.
Eric Seidel (no email)
Comment 4 2010-02-02 14:08:43 PST
Comment on attachment 47751 [details] Patch Marking r- since this change was reverted.
Chris Marrin
Comment 5 2010-02-05 15:50:20 PST
Created attachment 48270 [details] replacement patch fixing LayoutTests
Chris Marrin
Comment 6 2010-02-05 16:31:31 PST
Created attachment 48275 [details] Replacement patch with more description of what changed in each file
Chris Marrin
Comment 7 2010-02-05 17:13:57 PST
Landed in http://trac.webkit.org/changeset/54455
Note You need to log in before you can comment on or make changes to this bug.