|Summary:||Windows has out of date virtual function in GraphicsLayer (setContentsToVideo is now setContentsToMedia)|
|Product:||WebKit||Reporter:||Chris Marrin <cmarrin>|
|Component:||Media||Assignee:||Chris Marrin <cmarrin>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Chris Marrin 2010-01-29 14:43:04 PST
Simon recently changed the virtual function name in GraphicsLayer from setContentsToVideo to setContentsToMedia. The name needs to be updated in the Windows build
Comment 2 Brian Weinstein 2010-01-31 00:42:16 PST
Chris, I'm worried this patch broke a bunch of tests: http://build.webkit.org/results/Windows%20Release%20(Tests)/r54108%20(8573)/results.html If you look at some of the results in the failing media tests - for example: http://build.webkit.org/results/Windows%20Release%20(Tests)/r54108%20(8573)/media/controls-styling-pretty-diff.html They seem to be failing due to layer issues, and these failures started between r54093 and r54095, so I think this r54095 is the culprit.
Comment 3 Eric Carlson 2010-01-31 20:57:11 PST
Reverted the changes for now.
Comment 4 Eric Seidel (no email) 2010-02-02 14:08:43 PST
Comment on attachment 47751 [details] Patch Marking r- since this change was reverted.
Comment 5 Chris Marrin 2010-02-05 15:50:20 PST
Created attachment 48270 [details] replacement patch fixing LayoutTests
Comment 6 Chris Marrin 2010-02-05 16:31:31 PST
Created attachment 48275 [details] Replacement patch with more description of what changed in each file