Bug 34348 - Windows has out of date virtual function in GraphicsLayer (setContentsToVideo is now setContentsToMedia)
Summary: Windows has out of date virtual function in GraphicsLayer (setContentsToVideo...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Marrin
Depends on:
Reported: 2010-01-29 14:43 PST by Chris Marrin
Modified: 2010-02-05 17:13 PST (History)
2 users (show)

See Also:

Patch (6.14 KB, patch)
2010-01-29 17:53 PST, Chris Marrin
eric: review-
Details | Formatted Diff | Diff
replacement patch fixing LayoutTests (6.86 KB, patch)
2010-02-05 15:50 PST, Chris Marrin
no flags Details | Formatted Diff | Diff
Replacement patch with more description of what changed in each file (7.18 KB, patch)
2010-02-05 16:31 PST, Chris Marrin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2010-01-29 14:43:04 PST
Simon recently changed the virtual function name in GraphicsLayer from setContentsToVideo to setContentsToMedia. The name needs to be updated in the Windows build
Comment 1 Chris Marrin 2010-01-29 17:53:55 PST
Created attachment 47751 [details]
Comment 2 Brian Weinstein 2010-01-31 00:42:16 PST
Chris, I'm worried this patch broke a bunch of tests:


If you look at some of the results in the failing media tests - for example:


They seem to be failing due to layer issues, and these failures started between r54093 and r54095, so I think this r54095 is the culprit.
Comment 3 Eric Carlson 2010-01-31 20:57:11 PST
Reverted the changes for now.
Comment 4 Eric Seidel (no email) 2010-02-02 14:08:43 PST
Comment on attachment 47751 [details]

Marking r- since this change was reverted.
Comment 5 Chris Marrin 2010-02-05 15:50:20 PST
Created attachment 48270 [details]
replacement patch fixing LayoutTests
Comment 6 Chris Marrin 2010-02-05 16:31:31 PST
Created attachment 48275 [details]
Replacement patch with more description of what changed in each file
Comment 7 Chris Marrin 2010-02-05 17:13:57 PST
Landed in http://trac.webkit.org/changeset/54455