Bug 34343

Summary: Client-based Geolocation starts updating before getting consent from the user
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Description Steve Falkenburg 2010-01-29 13:22:21 PST 
Client-based Geolocation starts updating before getting consent from the user
Comment 1 Steve Falkenburg 2010-01-29 13:35:10 PST 
Created attachment 47732 [details]
Patch
Comment 2 Darin Adler 2010-01-29 13:45:23 PST 
Comment on attachment 47732 [details]
Patch

> +            ASSERT(m_frame);
> +            Page* page = m_frame->page();
> +            ASSERT(page);
> +            page->geolocationController()->addObserver(this);

What guarantees they are non-zero? You should figure out what the right behavior would be in those cases and handle instead of asserting.

Otherwise, r=me
Comment 3 Steve Falkenburg 2010-01-29 14:08:29 PST 
Committed r54079: <http://trac.webkit.org/changeset/54079>