Bug 34343

Summary: Client-based Geolocation starts updating before getting consent from the user
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Steve Falkenburg
Reported 2010-01-29 13:22:21 PST
Client-based Geolocation starts updating before getting consent from the user
Attachments
Patch (4.05 KB, patch)
2010-01-29 13:35 PST, Steve Falkenburg 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-01-29 13:35:10 PST
Created attachment 47732 [details] Patch
Darin Adler
Comment 2 2010-01-29 13:45:23 PST
Comment on attachment 47732 [details] Patch > + ASSERT(m_frame); > + Page* page = m_frame->page(); > + ASSERT(page); > + page->geolocationController()->addObserver(this); What guarantees they are non-zero? You should figure out what the right behavior would be in those cases and handle instead of asserting. Otherwise, r=me
Steve Falkenburg
Comment 3 2010-01-29 14:08:29 PST
Committed r54079: <http://trac.webkit.org/changeset/54079>
Note You need to log in before you can comment on or make changes to this bug.