Summary: | Cannot inspect Web Inspector in QtLauncher | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebKit Qt | Assignee: | Jessie Berlin <jberlin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | jberlin, laszlo.gombos, psycovic | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Jessie Berlin
2010-01-29 06:35:48 PST
Created attachment 47903 [details]
Patch to enable inspecting the web inspector in the QtLauncher
Comment on attachment 47903 [details] Patch to enable inspecting the web inspector in the QtLauncher I love the patch. It sucks to have comments on a one liner. So if you fix them you can land the patch rightaway. > + Need a short description and bug URL (OOPS!) Please remove this. You have done everything that is needed for this. > InspectorClientWebPage(QObject* parent = 0) > - : QWebPage(parent) > + : QWebPage(parent) Even if you fix the style, we normally tend to do this in two separate commits. You have my rubber stamp to fix this style issue with the code. (In reply to comment #2) > (From update of attachment 47903 [details]) > I love the patch. It sucks to have comments on a one liner. So if you fix them > you can land the patch rightaway. > So r=you on the first patch which just removes the line setting the DeveloperExtraEnabled setting and then rs=you on a second patch that fixes the style? Or do you want me to repost the first patch here? > > > + Need a short description and bug URL (OOPS!) > > Please remove this. You have done everything that is needed for this. Whoops! Sorry about that. > > > InspectorClientWebPage(QObject* parent = 0) > > - : QWebPage(parent) > > + : QWebPage(parent) > > Even if you fix the style, we normally tend to do this in two separate commits. > You have my rubber stamp to fix this style issue with the code. Enabled inspecting the web inspector in the qt launcher: http://trac.webkit.org/changeset/54233 Will commit the style change next. (In reply to comment #4) > Enabled inspecting the web inspector in the qt launcher: > > http://trac.webkit.org/changeset/54233 > > Will commit the style change next. Committed style change: http://trac.webkit.org/changeset/54236 Closing bug. |