Summary: | Web Inspector: wire together buttons on welcome view and on status bar | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Mikhail Naganov <mnaganov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | pfeldman | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Mikhail Naganov
2010-01-29 02:43:08 PST
Created attachment 47692 [details]
proposed patch
Comment on attachment 47692 [details]
proposed patch
It is now even more confusing - once you toggle a button, welcome message stops making sense: it suggests that red button starts the profiler.
Created attachment 51745 [details] another approach OK, another approach, this time by limiting functionality. This is how it looks like: http://i42.tinypic.com/dgt5wk.png Comment on attachment 51745 [details]
another approach
Note that you could attach the screenshot to the bug.
Manually committed r56711: http://trac.webkit.org/changeset/56711 Author: mnaganov@chromium.org <mnaganov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> Date: Mon Mar 29 08:52:19 2010 +0000 2010-03-29 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Remove a possibility of confusion from Profiles panel Welcome screen by turning buttons into non-clickable glyphs. Also, span instructions alongside panel width. https://bugs.webkit.org/show_bug.cgi?id=34319 * English.lproj/localizedStrings.js: * inspector/front-end/ProfileView.js: (WebInspector.CPUProfileType.prototype.get welcomeMessage): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype._addWelcomeMessage): * inspector/front-end/inspector.css: (.panel-enabler-view.welcome .instructions): (.panel-enabler-view.welcome button.status-bar-item): * src/js/HeapProfilerPanel.js: (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage): |