Bug 34312

Summary: [Win] Utilize PrintContext to share the printing code with other ports
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: WebCore Misc.Assignee: Shinichiro Hamaji <hamaji>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, bweinstein, eric, hayato, sfalken, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
Attachments:
Description Flags
Patch v1 eric: review+

Shinichiro Hamaji
Reported 2010-01-28 23:05:55 PST
PrintContext::computePageRects is very similar to computePageRectsForFrame in WebCore/page/FrameWin.cpp. We should be able to share the code. This is another instance of Bug 18578. A patch will come soon later.
Attachments
Patch v1 (4.91 KB, patch)
2010-01-28 23:50 PST, Shinichiro Hamaji 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-01-28 23:50:07 PST
Created attachment 47683 [details] Patch v1
Shinichiro Hamaji
Comment 2 2010-01-28 23:53:18 PST
I manually tested this patch by print-preview and didn't see any difference between before and after this patch. Please let me know if there are something I must check.
Eric Seidel (no email)
Comment 3 2010-02-01 15:51:58 PST
Comment on attachment 47683 [details] Patch v1 Looks sane to me.
Eric Seidel (no email)
Comment 4 2010-02-01 16:13:34 PST
Attachment 47683 [details] was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit.
Shinichiro Hamaji
Comment 5 2010-02-02 03:07:33 PST
Committed r54221: <http://trac.webkit.org/changeset/54221>
Note You need to log in before you can comment on or make changes to this bug.