Bug 3429

Summary:

Text transformed with text-transform does not copy with transform applied

Product:

WebKit

Reporter:

Andrew Wellington <andrew>

Component:

HTML Editing

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, nickshanks

Priority:

Version:

412

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch to use renderer string instead of DOM string	darin: review+
Regression Test	none

Andrew Wellington

Reported 2005-06-10 23:20:14 PDT

When copying text that has been transformed using the text-transform CSS1 property, the transformations are not applied to the copied text. This can be reproduced by copying transformed text from the regression test: layout-tests/css1/text_properties/text_transform.html For example, what is displayed as: This Paragraph Is Capitalized is copied as: This paragraph is capitalized

Attachments
Patch to use renderer string instead of DOM string (1000 bytes, patch) 2005-08-14 02:57 PDT, Andrew Wellington	darin: review+	Details Formatted Diff Diff
Regression Test (1.45 KB, text/html) 2005-08-14 21:23 PDT, Andrew Wellington	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Allan Sandfeld Jensen

Comment 1 2005-06-13 03:46:06 PDT

This has been fixed in Konqueror

Darin Adler

Comment 2 2005-08-14 02:03:05 PDT

*** Bug 4427 has been marked as a duplicate of this bug. ***

Darin Adler

Comment 3 2005-08-14 02:04:23 PDT

TextIterator is the thing that would need to be changed, in visible_text.h/cpp.

Andrew Wellington

Comment 4 2005-08-14 02:57:07 PDT

Created attachment 3378 [details] Patch to use renderer string instead of DOM string Modify visible_text.cpp to use the string from the renderer not the DOM in handleTextNode and handleTextBox

Darin Adler

Comment 5 2005-08-14 08:48:02 PDT

Comment on attachment 3378 [details] Patch to use renderer string instead of DOM string This looks like the right fix. But we also need a test to check in at the same time. I'm going to set this to review-, but it should be set to review+ once we have a suitable test.

Darin Adler

Comment 6 2005-08-14 21:06:16 PDT

Two ways to write the test: 1) Use the "innerText" method. 2) Use execCommand("PasteAndMatchStyle") to make a test that will work in DumpRenderTree, although not in Safari.

Darin Adler

Comment 7 2005-08-14 21:07:24 PDT

(Because the innerText method shares the same code path with copy.)

Andrew Wellington

Comment 8 2005-08-14 21:23:15 PDT

Created attachment 3391 [details] Regression Test Proposed regression test

Note You need to log in before you can comment on or make changes to this bug.