Bug 34256

Summary: Some js files in LayoutTests/fast/event/script-tests should move to LayoutTests/fast/event/touch/script-tests.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: commit-queue
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
move-js-files
none
Move JS files none

Hayato Ito
Reported 2010-01-28 05:55:42 PST
The following three files in LayoutTests/fast/event/script-tests directory should move to LayoutTests/fast/event/touch/script-tests directory. - basic-touch-event.js - create-touch-event.js - send-oncancel-event.js, Unless that, make-test-script-wrapper wrongly genereates html files in LayoutTests/fast/event directory instead of LayoutTests/fast/event/touch, where the corresponding {...}-expected.txt files exist.
Attachments
move-js-files (17.83 KB, patch)
2010-01-28 06:01 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Move JS files (19.22 KB, patch)
2010-01-28 21:36 PST, Hayato Ito 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2010-01-28 06:01:25 PST
Created attachment 47609 [details] move-js-files
Hayato Ito
Comment 2 2010-01-28 06:02:38 PST
I've moved the js files and updated the html files.
Hayato Ito
Comment 3 2010-01-28 06:08:20 PST
Hmm. I am using git and I used webkit-patch script to send a patch. It seems webkit-patch didn't generate a patch that is aware of 'file renaming'. I'll send a patch using pure svn later.
Hayato Ito
Comment 4 2010-01-28 21:36:59 PST
Created attachment 47674 [details] Move JS files I've used 'svn-create-patch' script this time to make the patch to preserve 'file renaming' infomation.
WebKit Commit Bot
Comment 5 2010-02-02 14:18:11 PST
Comment on attachment 47674 [details] Move JS files Clearing flags on attachment: 47674 Committed r54253: <http://trac.webkit.org/changeset/54253>
WebKit Commit Bot
Comment 6 2010-02-02 14:18:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.