Bug 34254

Summary:

[WML] Build error in WML enabled build.

Product:

WebKit

Reporter:

Nayan <nayankk>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch to fix compilation error.	none

Description Nayan 2010-01-28 05:26:16 PST

With the changeset 53514, WML enabled builds are failing with following errors,

  CXX    WebCore/wml/libwebkit_1_0_la-WMLDocument.lo
  CXX    WebCore/wml/libwebkit_1_0_la-WMLElement.lo
WebCore/wml/WMLDocument.cpp: In constructor ‘WebCore::WMLDocument::WMLDocument(WebCore::Frame*)’:
WebCore/wml/WMLDocument.cpp:39: error: no matching function for call to ‘WebCore::Document::Document(WebCore::Frame*&, bool)’
./WebCore/dom/Document.h:938: note: candidates are: WebCore::Document::Document(WebCore::Frame*, bool, bool)
./WebCore/dom/Document.h:178: note:                 WebCore::Document::Document(const WebCore::Document&)
make[1]: *** [WebCore/wml/libwebkit_1_0_la-WMLDocument.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/nayan/webkit/WebKit-SVN'
make: *** [all] Error 2

Comment 1 Nayan 2010-01-28 05:38:00 PST

Created attachment 47608 [details]
Patch to fix compilation error.

Comment 2 Nayan 2010-01-28 07:03:49 PST

Comment on attachment 47608 [details]
Patch to fix compilation error.

My mistake, un-intentionally set review flag to '+' instead of '?'!. Correcting it.

Comment 3 Laszlo Gombos 2010-01-28 12:25:49 PST

Comment on attachment 47608 [details]
Patch to fix compilation error.

r=me.

Comment 4 WebKit Commit Bot 2010-01-28 17:15:14 PST

Comment on attachment 47608 [details]
Patch to fix compilation error.

Clearing flags on attachment: 47608

Committed r54030: <http://trac.webkit.org/changeset/54030>

Comment 5 WebKit Commit Bot 2010-01-28 17:15:18 PST

All reviewed patches have been landed.  Closing bug.