Bug 34227

Summary: MessageEvent.data should deserialize in the context of the MessageEvent's global object
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Description Oliver Hunt 2010-01-27 14:38:34 PST 
MessageEvent.data should deserialize in the context of the MessageEvent's global object
Comment 1 Oliver Hunt 2010-01-27 16:23:44 PST 
Created attachment 47572 [details]
Patch
Comment 2 Oliver Hunt 2010-01-27 16:24:30 PST 
Comment on attachment 47572 [details]
Patch

Don't want actual review yet (as i don't have testcases yet)
Comment 3 Oliver Hunt 2010-01-27 20:18:56 PST 
Created attachment 47587 [details]
Patch
Comment 4 WebKit Review Bot 2010-01-27 20:30:01 PST 
Attachment 47587 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/216413
Comment 5 Maciej Stachowiak 2010-01-27 20:39:43 PST 
Comment on attachment 47587 [details]
Patch

r=me
Comment 6 Oliver Hunt 2010-01-27 20:47:15 PST 
Committed r53969: <http://trac.webkit.org/changeset/53969>
Comment 7 Eric Seidel (no email) 2010-01-27 23:58:59 PST 
This change was a flamethrower.  But I think most of the tree has been put out.  Gtk still looks broken though.
Comment 8 Eric Seidel (no email) 2010-01-27 23:59:46 PST 
--- /var/lib/buildbot/build/gtk-linux-release/build/layout-test-results/fast/dom/Window/window-postmessage-clone-frames-expected.txt	2010-01-27 23:38:26.000000000 -0800
+++ /var/lib/buildbot/build/gtk-linux-release/build/layout-test-results/fast/dom/Window/window-postmessage-clone-frames-actual.txt	2010-01-27 23:38:26.000000000 -0800
@@ -5,8 +5,8 @@
 PASS: (frames[0].tests[1]).event.data instanceof (frames[0]).Array is true of type boolean
 PASS: (frames[0].tests[2]).eventData instanceof (frames[0]).Date is true of type boolean
 PASS: (frames[0].tests[2]).event.data instanceof (frames[0]).Date is true of type boolean
-PASS: (frames[0].tests[3]).eventData instanceof (frames[0]).File is true of type boolean
-PASS: (frames[0].tests[3]).event.data instanceof (frames[0]).File is true of type boolean
+FAIL: (frames[0].tests[3]).eventData instanceof (frames[0]).File is false should be true of type boolean
+FAIL: (frames[0].tests[3]).event.data instanceof (frames[0]).File is false should be true of type boolean
 PASS: (frames[0].tests[4]).eventData instanceof (frames[0]).FileList is true of type boolean
 PASS: (frames[0].tests[4]).event.data instanceof (frames[0]).FileList is true of type boolean