Bug 34227

Summary: MessageEvent.data should deserialize in the context of the MessageEvent's global object
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Oliver Hunt
Reported 2010-01-27 14:38:34 PST
MessageEvent.data should deserialize in the context of the MessageEvent's global object
Attachments
Patch (12.48 KB, patch)
2010-01-27 16:23 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (19.49 KB, patch)
2010-01-27 20:18 PST, Oliver Hunt 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-01-27 16:23:44 PST
Created attachment 47572 [details] Patch
Oliver Hunt
Comment 2 2010-01-27 16:24:30 PST
Comment on attachment 47572 [details] Patch Don't want actual review yet (as i don't have testcases yet)
Oliver Hunt
Comment 3 2010-01-27 20:18:56 PST
Created attachment 47587 [details] Patch
WebKit Review Bot
Comment 4 2010-01-27 20:30:01 PST
Attachment 47587 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/216413
Maciej Stachowiak
Comment 5 2010-01-27 20:39:43 PST
Comment on attachment 47587 [details] Patch r=me
Oliver Hunt
Comment 6 2010-01-27 20:47:15 PST
Committed r53969: <http://trac.webkit.org/changeset/53969>
Eric Seidel (no email)
Comment 7 2010-01-27 23:58:59 PST
This change was a flamethrower. But I think most of the tree has been put out. Gtk still looks broken though.
Eric Seidel (no email)
Comment 8 2010-01-27 23:59:46 PST
--- /var/lib/buildbot/build/gtk-linux-release/build/layout-test-results/fast/dom/Window/window-postmessage-clone-frames-expected.txt 2010-01-27 23:38:26.000000000 -0800 +++ /var/lib/buildbot/build/gtk-linux-release/build/layout-test-results/fast/dom/Window/window-postmessage-clone-frames-actual.txt 2010-01-27 23:38:26.000000000 -0800 @@ -5,8 +5,8 @@ PASS: (frames[0].tests[1]).event.data instanceof (frames[0]).Array is true of type boolean PASS: (frames[0].tests[2]).eventData instanceof (frames[0]).Date is true of type boolean PASS: (frames[0].tests[2]).event.data instanceof (frames[0]).Date is true of type boolean -PASS: (frames[0].tests[3]).eventData instanceof (frames[0]).File is true of type boolean -PASS: (frames[0].tests[3]).event.data instanceof (frames[0]).File is true of type boolean +FAIL: (frames[0].tests[3]).eventData instanceof (frames[0]).File is false should be true of type boolean +FAIL: (frames[0].tests[3]).event.data instanceof (frames[0]).File is false should be true of type boolean PASS: (frames[0].tests[4]).eventData instanceof (frames[0]).FileList is true of type boolean PASS: (frames[0].tests[4]).event.data instanceof (frames[0]).FileList is true of type boolean
Note You need to log in before you can comment on or make changes to this bug.