Bug 34226

Summary: [v8]: Regression: onunload event handling
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: FramesAssignee: John Abd-El-Malek <jam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch
dglazkov: review-
Renamed both tests to use dashes none

Description John Abd-El-Malek 2010-01-27 13:39:00 PST
(from http://code.google.com/p/chromium/issues/detail?id=33242)

If a page removes an iframe using removeChild and that frame sleeps in its unload handler, then when we terminate JS, we'll also terminate the outer page's JS.  Dimitri suggested throwing an exception instead.
Comment 1 John Abd-El-Malek 2010-01-27 14:27:46 PST
Created attachment 47563 [details]
Proposed patch
Comment 2 Dimitri Glazkov (Google) 2010-01-27 14:30:17 PST
Comment on attachment 47563 [details]
Proposed patch

I think this is a much gentler, kinder version of the change. I like it. Small nit: can you convert the file name of the test to dashes? We don't really use underscores.
Comment 3 John Abd-El-Malek 2010-01-27 15:56:52 PST
Created attachment 47569 [details]
Renamed both tests to use dashes
Comment 4 Dimitri Glazkov (Google) 2010-01-27 15:57:57 PST
Comment on attachment 47569 [details]
Renamed both tests to use dashes

ok.
Comment 5 WebKit Commit Bot 2010-01-27 17:41:38 PST
Comment on attachment 47569 [details]
Renamed both tests to use dashes

Clearing flags on attachment: 47569

Committed r53965: <http://trac.webkit.org/changeset/53965>
Comment 6 WebKit Commit Bot 2010-01-27 17:41:45 PST
All reviewed patches have been landed.  Closing bug.