Summary: | [v8]: Regression: onunload event handling | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Abd-El-Malek <jam> | ||||||
Component: | Frames | Assignee: | John Abd-El-Malek <jam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dglazkov | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
John Abd-El-Malek
2010-01-27 13:39:00 PST
Created attachment 47563 [details]
Proposed patch
Comment on attachment 47563 [details]
Proposed patch
I think this is a much gentler, kinder version of the change. I like it. Small nit: can you convert the file name of the test to dashes? We don't really use underscores.
Created attachment 47569 [details]
Renamed both tests to use dashes
Comment on attachment 47569 [details]
Renamed both tests to use dashes
ok.
Comment on attachment 47569 [details] Renamed both tests to use dashes Clearing flags on attachment: 47569 Committed r53965: <http://trac.webkit.org/changeset/53965> All reviewed patches have been landed. Closing bug. |