Bug 34224

Summary:

[v8] minor cosmetic fix in V8 bindings codegenerator

Product:

WebKit

Reporter:

anton muhin <antonm>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
First take	none

anton muhin

Reported 2010-01-27 12:19:06 PST

Need to swap , and a space.

Attachments
First take (1.33 KB, patch) 2010-01-27 12:22 PST, anton muhin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

anton muhin

Comment 1 2010-01-27 12:22:04 PST

Created attachment 47557 [details] First take

anton muhin

Comment 2 2010-01-27 13:31:48 PST

Comment on attachment 47557 [details] First take Thanks, David.

WebKit Commit Bot

Comment 3 2010-01-27 14:41:58 PST

Comment on attachment 47557 [details] First take Clearing flags on attachment: 47557 Committed r53953: <http://trac.webkit.org/changeset/53953>

WebKit Commit Bot

Comment 4 2010-01-27 14:42:03 PST

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 5 2010-01-27 23:45:14 PST

Oh good. I thought v9 was making a comeback.

anton muhin

Comment 6 2010-01-28 03:36:24 PST

(In reply to comment #5) > Oh good. I thought v9 was making a comeback. Huh? Oh should I take it off the bug?

Adam Barth

Comment 7 2010-01-28 08:30:42 PST

For a while, there were two versions of the V8 API, one called v8 and one called v9. If you think life is confusing now, you should have seen that! Thankfully, v9 killed v8, so the API we use now is technically v9, but we kept the v8 name because sounds better. :)

anton muhin

Comment 8 2010-01-28 08:37:05 PST

(In reply to comment #7) > For a while, there were two versions of the V8 API, one called v8 and one > called v9. If you think life is confusing now, you should have seen that! > Thankfully, v9 killed v8, so the API we use now is technically v9, but we kept > the v8 name because sounds better. :) Cool. Thanks a lot for explanations.

Note You need to log in before you can comment on or make changes to this bug.