Bug 34223

Summary:

Remove trailing \ from inline function code

Product:

WebKit

Reporter:

anton muhin <antonm>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
First patch	none
Adding spaces around -	none

anton muhin

Reported 2010-01-27 12:04:32 PST

That's most probably remnants of refactoring which turned a macro into a function.

Attachments
First patch (1.63 KB, patch) 2010-01-27 12:07 PST, anton muhin	no flags	Details Formatted Diff Diff
Adding spaces around - (1.64 KB, patch) 2010-01-27 12:30 PST, anton muhin	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

anton muhin

Comment 1 2010-01-27 12:07:41 PST

Created attachment 47556 [details] First patch

Darin Adler

Comment 2 2010-01-27 12:27:45 PST

Comment on attachment 47556 [details] First patch Comments should also be "//" instead of "/*". Spaces should be around the "-" operator too, not just the "<<" operator.

anton muhin

Comment 3 2010-01-27 12:30:34 PST

Created attachment 47558 [details] Adding spaces around -

anton muhin

Comment 4 2010-01-27 12:31:12 PST

(In reply to comment #2) > (From update of attachment 47556 [details]) > Comments should also be "//" instead of "/*". > > Spaces should be around the "-" operator too, not just the "<<" operator. Thanks, done.

anton muhin

Comment 5 2010-01-27 13:32:41 PST

Comment on attachment 47558 [details] Adding spaces around - Thanks, Darin.

WebKit Commit Bot

Comment 6 2010-01-27 14:59:30 PST

Comment on attachment 47558 [details] Adding spaces around - Clearing flags on attachment: 47558 Committed r53954: <http://trac.webkit.org/changeset/53954>

WebKit Commit Bot

Comment 7 2010-01-27 14:59:35 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.