Bug 34200

Summary: Add valueAsNumber support for type=datetime-local
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 32696    
Bug Blocks:    
Attachments:
Description Flags
Proposed patch none

Description Kent Tamura 2010-01-26 22:49:38 PST
Add valueAsNumber support for type=datetime-local.  It was not implemented in Bug#32696.
Comment 1 Kent Tamura 2010-01-26 22:54:50 PST
Created attachment 47499 [details]
Proposed patch
Comment 2 Darin Adler 2010-01-27 15:42:32 PST
Comment on attachment 47499 [details]
Proposed patch

> +bool ISODateTime::setMillisecondsSinceEpochForDateTimeLocal(double ms)

Does ISODateTime really need a separate DateTimeLocal type? I guess it does just so it knows to omit the "Z".

r=me
Comment 3 Kent Tamura 2010-01-27 16:37:56 PST
(In reply to comment #2)
> Does ISODateTime really need a separate DateTimeLocal type? I guess it does
> just so it knows to omit the "Z".

I feel it is tricky to make a string for DateTime type by toString()+"Z".
Comment 4 WebKit Commit Bot 2010-01-27 17:24:16 PST
Comment on attachment 47499 [details]
Proposed patch

Clearing flags on attachment: 47499

Committed r53964: <http://trac.webkit.org/changeset/53964>
Comment 5 WebKit Commit Bot 2010-01-27 17:24:21 PST
All reviewed patches have been landed.  Closing bug.