Bug 34198

Summary: Ruby text should not inherit line-height
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rolandsteiner
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.google.com/support/forum/p/chrome/thread?tid=60b3b03abfc78055&hl=ja
Attachments:
Description Flags
Demo HTML
none
patch - reset line-height in the UA stylesheet
eric: review-
patch - reset line-height in the UA stylesheet, new layout test adele: review+

Kent Tamura
Reported 2010-01-26 22:02:29 PST
Created attachment 47493 [details] Demo HTML Reported in Google Chrome Help Forum (Japanese). If ruby base text has line-height CSS property, the ruby text for it also has the line-height in the current implementation. I'll attach a demo code. 'tttt' should not be placed apart from 'bbbb'.
Attachments
Demo HTML (153 bytes, text/html)
2010-01-26 22:02 PST, Kent Tamura 		no flags
Details
patch - reset line-height in the UA stylesheet (4.09 KB, patch)
2010-01-27 04:45 PST, Roland Steiner 		eric: review-
DetailsFormatted DiffDiff
patch - reset line-height in the UA stylesheet, new layout test (4.61 KB, patch)
2010-02-01 21:01 PST, Roland Steiner 		adele: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2010-01-27 04:45:36 PST
Created attachment 47518 [details] patch - reset line-height in the UA stylesheet
Eric Seidel (no email)
Comment 2 2010-02-01 15:42:53 PST
Comment on attachment 47518 [details] patch - reset line-height in the UA stylesheet Woh. Batman, I think we need a helper function in that test case (instead of 3 sets of the same copy/paste code). Why wouldnt' this be a script-test anyway?
Roland Steiner
Comment 3 2010-02-01 21:01:32 PST
Created attachment 47904 [details] patch - reset line-height in the UA stylesheet, new layout test Zounds, holy statement of what should have been obvious! A script-test is of course more appropriate. Changed the layout test as suggested.
Roland Steiner
Comment 4 2010-02-02 22:36:50 PST
Landed as rev. 54273
Note You need to log in before you can comment on or make changes to this bug.