Bug 34196

Summary: HTML5 Media Controls should have configurable fade transition
Product: WebKit Reporter: Nick Young <nicholas.young>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: adele, commit-queue, eric.carlson, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed change
none
Reviewed Patch.
commit-queue: review-, commit-queue: commit-queue-
Whoops. Apparently I wasn't supposed to do that. Original Patch.
eric.carlson: review+, commit-queue: commit-queue-
Updated Patch none

Description Nick Young 2010-01-26 20:20:13 PST
This bug addresses a //FIXME on line 48 in WebCore/rendering/RenderMedia.cpp.

HTML5 media controls currently have hard-coded, platform-independent duration values for the fade in and fade out transitions.
These should be configurable on a style or theme level.

This allows the transition to be controlled on a platform level.
This is of particular benefit to platforms wishing to avoid the composition of semitransparent controls on to video for performance reasons.

Affected Lines:
WebCore/rendering/RenderMedia.cpp: 48-50, 58, 70, 455-458

(Line numbers accurate at r53888)
Comment 1 Nick Young 2010-01-26 20:26:22 PST
Created attachment 47487 [details]
Proposed change

Fade in/out duration pulled from theme.
Comment 2 Eric Carlson 2010-01-27 07:50:53 PST
Comment on attachment 47487 [details]
Proposed change

r=me
Comment 3 Nick Young 2010-01-27 16:01:56 PST
Created attachment 47570 [details]
Reviewed Patch.

Added RevBy.
Ready for Commit Queue.
Comment 4 WebKit Commit Bot 2010-01-27 16:17:13 PST
Comment on attachment 47570 [details]
Reviewed Patch.

Rejecting patch 47570 from review queue.

nicholas.young@nokia.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 WebKit Commit Bot 2010-01-27 16:30:33 PST
Comment on attachment 47570 [details]
Reviewed Patch.

Rejecting patch 47570 from commit-queue.

nicholas.young@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 Nick Young 2010-01-27 16:30:46 PST
Created attachment 47573 [details]
Whoops. Apparently I wasn't supposed to do that. Original Patch.

Original Patch.
Comment 7 Eric Carlson 2010-01-27 16:54:39 PST
> Whoops. Apparently I wasn't supposed to do that. Original Patch.
> 
Just set the 'commit-queue?' flag when you attach a patch for review if you want it to be automatically submitted.
Comment 8 WebKit Commit Bot 2010-01-27 17:51:00 PST
Comment on attachment 47573 [details]
Whoops. Apparently I wasn't supposed to do that. Original Patch.

Rejecting patch 47573 from commit-queue.

Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1
Last 500 characters of output:
mmitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/i386/SelectionController.o /Users/eseidel/Projects/CommitQueue/WebCore/editing/SelectionController.cpp normal i386 c++ com.apple.compilers.gcc.4_2
	Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/i386/RenderThemeMac.o /Users/eseidel/Projects/CommitQueue/WebCore/rendering/RenderThemeMac.mm normal i386 objective-c++ com.apple.compilers.gcc.4_2
(27 failures)


Full output: http://webkit-commit-queue.appspot.com/results/215420
Comment 9 Eric Carlson 2010-01-27 18:06:18 PST
Oops, m_opacityAnimationStartTime and m_opacityAnimationDuration are doubles so mediaControlsFadeInDuration and mediaControlsFadeOutDuration need to return the same.
Comment 10 Nick Young 2010-01-27 18:17:06 PST
Created attachment 47585 [details]
Updated Patch

Fixing build on mac.
I somehow had it my mind that m_opacityAnimationDuration was a float and not a double.
Comment 11 Eric Carlson 2010-01-27 18:31:19 PST
Comment on attachment 47585 [details]
Updated Patch

Third time is a charm?

r=me
Comment 12 WebKit Commit Bot 2010-01-27 18:56:01 PST
Comment on attachment 47585 [details]
Updated Patch

Clearing flags on attachment: 47585

Committed r53966: <http://trac.webkit.org/changeset/53966>
Comment 13 WebKit Commit Bot 2010-01-27 18:56:07 PST
All reviewed patches have been landed.  Closing bug.