Bug 34190

Summary: [BREWMP] Remove COMPILE_ASSERT conflict with the underlying PLATFORM
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 33564    
Attachments:
Description Flags
Remove COMPILE_ASSERT conflict none

Description Kwang Yul Seo 2010-01-26 16:48:43 PST 
COMPILE_ASSERT conflicts with the underlying PLATFORM because it is defined both in WTF's Assertions.h and BREWMP's AEEClassIDs.h. Include "AEEClassIDs.h" in Assertions.h and undef COMPILE_ASSERT to avoid redefining COMPILE_ASSERT.
Comment 1 Kwang Yul Seo 2010-01-26 16:52:32 PST 
Created attachment 47462 [details]
Remove COMPILE_ASSERT conflict
Comment 2 Eric Seidel (no email) 2010-02-03 13:06:11 PST 
Comment on attachment 47462 [details]
Remove COMPILE_ASSERT conflict

It seems strange to me to include AEEClassIDs.h

I assume that's where COMPILE_ASSERT is defined?
Comment 3 WebKit Commit Bot 2010-02-03 13:43:43 PST 
Comment on attachment 47462 [details]
Remove COMPILE_ASSERT conflict

Clearing flags on attachment: 47462

Committed r54296: <http://trac.webkit.org/changeset/54296>
Comment 4 WebKit Commit Bot 2010-02-03 13:43:51 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Kwang Yul Seo 2010-02-03 18:59:00 PST 
(In reply to comment #2)
> (From update of attachment 47462 [details])
> It seems strange to me to include AEEClassIDs.h
> 
> I assume that's where COMPILE_ASSERT is defined?

Yes. COMPILE_ASSERT is defined in AEEClassIDs.h.