Bug 34187

Summary:

webkit-patch commit-queue should land patches optimistically

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+

Description Eric Seidel (no email) 2010-01-26 15:44:46 PST

webkit-patch commit-queue should land patches optimistically

Right now it builds and tests tip-of-tree first, and if the tests pass, applies the patch and builds and tests with the patch.

We should instead apply the patch, build and test, and if they pass land.
If tests didn't pass, try trunk.  If trunk passed, reject the patch.  Otherwise, spin.

Adam gets all the credit for this masterful idea.

Should make the commit-queue *much* faster.

Comment 1 Adam Barth 2010-03-31 12:27:09 PDT

Created attachment 52194 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-03-31 12:29:49 PDT

Comment on attachment 52194 [details]
Patch

Slightly confusing, but maximally awesome.

Comment 3 Adam Barth 2010-03-31 12:32:42 PDT

Committed r56857: <http://trac.webkit.org/changeset/56857>