Bug 34165

Summary: Web Inspector: add support for breakpoints, messages and search into the SourceFrame2.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change. timothy: review+

Description Pavel Feldman 2010-01-26 05:24:34 PST
Patch to follow shortly.
Comment 1 Pavel Feldman 2010-01-26 05:27:26 PST
Created attachment 47406 [details]
[PATCH] Proposed change.
Comment 2 Timothy Hatcher 2010-01-26 08:25:04 PST
Comment on attachment 47406 [details]
[PATCH] Proposed change.

> +            var column = line.indexOf(query);

This will be more restrictive than our current search. We are currently do a case insensitive search.
Comment 3 Pavel Feldman 2010-01-26 08:41:06 PST
(In reply to comment #2)
> (From update of attachment 47406 [details])
> > +            var column = line.indexOf(query);
> 
> This will be more restrictive than our current search. We are currently do a
> case insensitive search.

I'll add toLowerCase or do a regex in the subsequent patch.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/SourceFrame2.js
	M	WebCore/inspector/front-end/TextEditor.js
	M	WebCore/inspector/front-end/TextEditorHighlighter.js
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/textEditor.css
Committed r53856