Bug 34162 – [Android] [Qt] Touch event page co-ordinates are incorrect when touch is received in an iframe.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Ben Murdoch]

The pageX/pageY co-ordinates in a touch should be relative to the containing frame. If the target element is in an iframe, the code currently does not readjust the page co-ordinates to be relative to that iframe but leaves them relative to the main frame.

Patch and test to follow. The patch also renames a variable in the Android specific code to more clearly reflect it's contents.

[Ben Murdoch]

Created attachment 47405 [details]
Proposed patch and updated test.

[Ben Murdoch]

Created attachment 47420 [details]
Proposed patch and updated test.

This patch additionally removes some dead code.

[WebKit Commit Bot]

Comment on attachment 47420 [details]
Proposed patch and updated test.

Rejecting patch 47420 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
int.h
	M	WebCore/platform/android/PlatformTouchEventAndroid.cpp
	M	WebCore/platform/android/PlatformTouchPointAndroid.cpp
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/LayoutTests/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 558


Full output: http://webkit-commit-queue.appspot.com/results/215684

[Ben Murdoch]

My bad, I have a duplicate entry in the change log. Will remove and land manually.

[Ben Murdoch]

Landed as r53994.

[Aurélio Santos]

This problem is still occurring to me in some webkit browsers when a CSS transition is applied to the iframe element. The browsers that I tested and saw this problem still happening are:

iOS5 Safari Mobile. Webkit version: 534.46
iOS6 Safari Mobile. Webkit version: 536.26
Android 4.0.3 stock browser. Webkit version: 534.30
Tizen Browser. Webkit version: 537.3

Could there have been a regression?

[Aurélio Santos]

I have created a simple test to show this problem happening on the specified browsers:

http://jsfiddle.net/aurhe/kQ8P4/3/embedded/result/