Bug 34161 – Local scope is shown as With scope in scope chain pane

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Yury Semikhatsky]

When debugger is paused on a breakpoint Local scope is displayed as With scope and 'this' variable is missing in it. This is a regression after http://trac.webkit.org/changeset/53766

[Oliver Hunt]

Any word on this?

[Oliver Hunt]

This only happens if the global object has a property with the same name of a variable in the scope chain :-/

[Yury Semikhatsky]

Created attachment 47538 [details]
patch

[Yury Semikhatsky]

Created attachment 47539 [details]
patch

Added ChangeLog entry.

[Oliver Hunt]

Comment on attachment 47539 [details]
patch

r=me

[Yury Semikhatsky]

Comment on attachment 47539 [details]
patch

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/bindings/js/JSInjectedScriptHostCustom.cpp
	M	WebCore/inspector/InjectedScriptHost.idl
	M	WebCore/inspector/front-end/InjectedScript.js
	A	WebCore/manual-tests/inspector/debugger-scopes-inspection.html
Committed r53945

[Darin Adler]

Comment on attachment 47539 [details]
patch

> +JSValue JSInjectedScriptHost::isActivation(ExecState* exec, const ArgList& args)
> +{
> +    if (args.size() < 1)
> +        return jsUndefined();
> +
> +    JSValue value = args.at(0);
> +    if (!value.isObject())
> +        return jsBoolean(false);
> +
> +    JSObject* object = value.toObject(exec);
> +    return jsBoolean(object->isActivationObject());

This is unnecessarily inefficient. There is no need to check args.size() at all, since args.at(0) already does. And the toObject function is not needed for a value already known to be an object. The function could be this:

    JSObject* object = args.at(0).getObject();
    return jsBoolean(object && object->isActivationObject());

[Yury Semikhatsky]

Created attachment 47598 [details]
patch

isActivation code is simplified according to Darin's suggestion.

[Yury Semikhatsky]

I'd like to improve the code.

[WebKit Commit Bot]

Comment on attachment 47598 [details]
patch

Clearing flags on attachment: 47598

Committed r53993: <http://trac.webkit.org/changeset/53993>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.