Bug 34149

Summary: Some methods in JSC JNI bridge need more error checking of results from JNI.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Preliminary patch (not even built!)
none
a patch andersca: review+

Gavin Barraclough
Reported 2010-01-25 16:28:23 PST
In JNIUtility.h, callJNIMethodV<jobject> might return null (from CallObjectMethodV, via JNICaller<jobject>::callV) if an exception is thrown. All clients of callJNIMethodV<jobject> that are calling methods on the returned object should null check first.
Attachments
Preliminary patch (not even built!) (13.69 KB, patch)
2010-01-25 16:44 PST, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
a patch (15.50 KB, patch)
2010-01-25 19:14 PST, Gavin Barraclough 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-01-25 16:44:05 PST
Created attachment 47376 [details] Preliminary patch (not even built!)
Gavin Barraclough
Comment 2 2010-01-25 19:14:56 PST
Created attachment 47381 [details] a patch
Anders Carlsson
Comment 3 2010-01-26 13:46:07 PST
Comment on attachment 47381 [details] a patch Looks great! r=me with the changes we discussed (Change "[UNKNOWN ...]" to simply "Unknown")
Gavin Barraclough
Comment 4 2010-01-26 14:01:12 PST
Transmitting file data ....... Committed revision 53865.
Note You need to log in before you can comment on or make changes to this bug.