Bug 3412

Summary:

Object.prototype is missing toLocaleString, isPrototypeOf and propertyIsEnumerable

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

New Bugs

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren

Priority:

Version:

412

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Implementation of Object.prototype.toLocaleString	none
Implementation of Object.prototype.toLocaleString	mjs: review+
/fast/js/object-prototype-toLocaleString.html	none
/fast/js/object-prototype-toLocaleString.html	none

Mark Rowe (bdash)

Reported 2005-06-10 07:53:00 PDT

Section 15.2.4 of ECMA-262 specification lists toString, toLocaleString, valueOf, hasOwnProperty, isPrototypeOf and propertyIsEnumerable. WebKit currently only supports toString and valueOf. Bug #3293 covers hasOwnProperty.

Attachments
Implementation of Object.prototype.toLocaleString (2.17 KB, patch) 2005-06-13 05:26 PDT, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Implementation of Object.prototype.toLocaleString (2.17 KB, patch) 2005-07-13 16:47 PDT, Geoffrey Garen	mjs: review+	Details Formatted Diff Diff
/fast/js/object-prototype-toLocaleString.html (903 bytes, text/html) 2005-07-13 16:48 PDT, Geoffrey Garen	no flags	Details
/fast/js/object-prototype-toLocaleString.html (1009 bytes, text/html) 2005-07-14 10:04 PDT, Geoffrey Garen	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2005-06-13 05:26:56 PDT

Created attachment 2293 [details] Implementation of Object.prototype.toLocaleString

Geoffrey Garen

Comment 2 2005-07-13 16:34:32 PDT

*** Bug 3989 has been marked as a duplicate of this bug. ***

Geoffrey Garen

Comment 3 2005-07-13 16:47:54 PDT

Created attachment 2951 [details] Implementation of Object.prototype.toLocaleString Previous patch had merge conflicts.

Geoffrey Garen

Comment 4 2005-07-13 16:48:45 PDT

Created attachment 2952 [details] /fast/js/object-prototype-toLocaleString.html layout test

Maciej Stachowiak

Comment 5 2005-07-13 19:53:02 PDT

Comment on attachment 2951 [details] Implementation of Object.prototype.toLocaleString r=me if the testing shows this matches other browsers.

Geoffrey Garen

Comment 6 2005-07-14 10:04:17 PDT

Created attachment 2961 [details] /fast/js/object-prototype-toLocaleString.html better output on failure

Geoffrey Garen

Comment 7 2005-07-14 10:12:39 PDT

(In reply to comment #5) Firefox and WinIE match. Mac IE doesn't, because it doesn't implement toLocaleString() at all. Upshot: I'll land the patch.

Geoffrey Garen

Comment 8 2005-07-14 10:42:26 PDT

Bug #3999 tracks propertyIsEnumerable. Bug #4000 tracks isPrototypeOf. This bug is only for toLocaleString(), so I'm closing it.

Note You need to log in before you can comment on or make changes to this bug.