Bug 34060

Summary: check-webkit-style: Create a webkitpy/style/processors directory for the different processors
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Severity: Normal CC: abarth, cjerdonek, eric, hamaji, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Proposed patch eric: review+, cjerdonek: commit-queue-

Description Chris Jerdonek 2010-01-24 13:19:42 PST
This will be a bit nicer for us as we--

(1) Add a shared processor file containing logic and checks common to multiple processors (e.g. the tab-check FIXME)
(1) Add a Python processor.
(3) Break checker.py into more than one file.

I will be doing (1) soon.

The file moves can go like this:

cpp_style.py -> processors/cpp.py
text_style.py -> processors/text.py

(and similarly for the associated unit test files)
Comment 1 Chris Jerdonek 2010-01-26 07:34:44 PST
Created attachment 47411 [details]
Proposed patch
Comment 2 Eric Seidel (no email) 2010-01-26 12:08:33 PST
Comment on attachment 47411 [details]
Proposed patch

Assuming all you're doing is moving code, looks OK to me.
Comment 3 Chris Jerdonek 2010-01-26 18:09:52 PST
Comment on attachment 47411 [details]
Proposed patch

Going to use webkit-patch.
Comment 4 Chris Jerdonek 2010-01-26 18:56:50 PST
(In reply to comment #3)
> (From update of attachment 47411 [details])
> Going to use webkit-patch.

Semi-automatically committed r53882 (via webkit-patch):


Encountered this bug in the process: