Bug 34026

Summary: [V8] Making V8 generated classes' GetTemplate() function public
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Kavita Kanetkar <kkanetkar>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 32638    
Attachments:
Description Flags
GetTemplate() public and removed refs to V8CustomBinding.h none

Nate Chapin
Reported 2010-01-22 15:25:04 PST
All the logic for depending directly on V8<class>::GetTemplate() is in place for all but a couple classes (and those patches are in flight). Make GetTemplate() public. Also, while editing CodeGenetaorV8.pm, we should get rid of all the #includes of V8CustomBinding.h, since the generated bindings shouldn't need it any longer.
Attachments
GetTemplate() public and removed refs to V8CustomBinding.h (4.93 KB, patch)
2010-01-29 15:48 PST, Kavita Kanetkar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kavita Kanetkar
Comment 1 2010-01-29 15:48:00 PST
Created attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h
Nate Chapin
Comment 2 2010-02-01 12:45:00 PST
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h Looks good, thanks!
WebKit Commit Bot
Comment 3 2010-02-01 12:45:27 PST
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h Rejecting patch 47740 from review queue. japhet@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights.
Nate Chapin
Comment 4 2010-02-01 12:51:48 PST
I'll r+ this again once the commit-queue has been restarted :)
Eric Seidel (no email)
Comment 5 2010-02-01 13:28:25 PST
the commit-queue has been restarted and will now recognize nate as a reviewer.
Nate Chapin
Comment 6 2010-02-01 13:30:47 PST
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h r+ again then!
WebKit Commit Bot
Comment 7 2010-02-01 17:00:26 PST
Comment on attachment 47740 [details] GetTemplate() public and removed refs to V8CustomBinding.h Clearing flags on attachment: 47740 Committed r54179: <http://trac.webkit.org/changeset/54179>
WebKit Commit Bot
Comment 8 2010-02-01 17:00:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.