Bug 34025

Summary:

Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets

Product:

WebKit

Reporter:

Steve Falkenburg <sfalken>

Component:

WebKit Misc.

Assignee:

Steve Falkenburg <sfalken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none
updated patch	none
re-post patch now that style queue is fixed	darin: review+

Steve Falkenburg

Reported 2010-01-22 15:24:26 PST

Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.

Attachments
patch (16.65 KB, patch) 2010-01-22 15:28 PST, Steve Falkenburg	no flags	Details Formatted Diff Diff
updated patch (16.65 KB, patch) 2010-01-22 15:35 PST, Steve Falkenburg	no flags	Details Formatted Diff Diff
re-post patch now that style queue is fixed (16.65 KB, patch) 2010-01-22 16:41 PST, Steve Falkenburg	darin: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Steve Falkenburg

Comment 1 2010-01-22 15:28:12 PST

Created attachment 47236 [details] patch

WebKit Review Bot

Comment 2 2010-01-22 15:31:56 PST

Attachment 47236 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 94, in <module> main() File "WebKitTools/Scripts/check-webkit-style", line 87, in main style_checker.check_patch(patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch self.check_file(file_path, handle_style_error=error_for_patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file process_file(processor, file_path, handle_style_error) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file processor.process(lines) AttributeError: 'NoneType' object has no attribute 'process' If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 3 2010-01-22 15:32:31 PST

Attachment 47236 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/207040

Eric Seidel (no email)

Comment 4 2010-01-22 15:32:45 PST

Attachment 47236 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/207042

Steve Falkenburg

Comment 5 2010-01-22 15:35:51 PST

Created attachment 47239 [details] updated patch

WebKit Review Bot

Comment 6 2010-01-22 15:39:34 PST

Attachment 47239 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 94, in <module> main() File "WebKitTools/Scripts/check-webkit-style", line 87, in main style_checker.check_patch(patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 915, in check_patch self.check_file(file_path, handle_style_error=error_for_patch) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 883, in check_file process_file(processor, file_path, handle_style_error) File "/mnt/git/webkit-style-queue/WebKitTools/Scripts/webkitpy/style/checker.py", line 838, in _process_file processor.process(lines) AttributeError: 'NoneType' object has no attribute 'process' If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 7 2010-01-22 15:43:32 PST

Attachment 47239 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/207053

Steve Falkenburg

Comment 8 2010-01-22 15:47:48 PST

Style bot and Mac bot failure seem to be problems with the tools (not the patch). Or, the output is malformed from the tools.

Adam Barth

Comment 9 2010-01-22 15:59:11 PST

(In reply to comment #8) > Style bot and Mac bot failure seem to be problems with the tools (not the > patch). Or, the output is malformed from the tools. Just landed a fix for this in http://trac.webkit.org/changeset/53730

Steve Falkenburg

Comment 10 2010-01-22 16:41:09 PST

Created attachment 47244 [details] re-post patch now that style queue is fixed

Steve Falkenburg

Comment 11 2010-01-22 18:00:08 PST

http://trac.webkit.org/changeset/53746

Note You need to log in before you can comment on or make changes to this bug.