Bug 34024

Summary: Layout tests don't easily allow Geolocation to be on in only a subset of platforms
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
patch darin: review+

Steve Falkenburg
Reported 2010-01-22 15:14:46 PST
Test results for some of our tests intermix Geolocation properties in very large expected results. Maintaining results would be simpler if the Geolocation properties were excluded from unimportant tests and split into new tests where needed.
Attachments
patch (11.04 KB, patch)
2010-01-22 15:19 PST, Steve Falkenburg 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-01-22 15:19:53 PST
Created attachment 47233 [details] patch
Darin Adler
Comment 2 2010-01-22 16:48:36 PST
Wait, the trybots are showing red. Please don’t land until you find out why.
Steve Falkenburg
Comment 3 2010-01-22 16:57:57 PST
The EWS bots don't run the layout tests, and this patch only changes files in the LayoutTests tree, so the red qt and gtk results can't be from this patch.
Steve Falkenburg
Comment 4 2010-01-22 17:08:21 PST
http://trac.webkit.org/changeset/53740
Note You need to log in before you can comment on or make changes to this bug.