Bug 34024 - Layout tests don't easily allow Geolocation to be on in only a subset of platforms
Summary: Layout tests don't easily allow Geolocation to be on in only a subset of plat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-22 15:14 PST by Steve Falkenburg
Modified: 2010-01-22 17:08 PST (History)
1 user (show)

See Also:


Attachments
patch (11.04 KB, patch)
2010-01-22 15:19 PST, Steve Falkenburg
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Falkenburg 2010-01-22 15:14:46 PST
Test results for some of our tests intermix Geolocation properties in very large expected results.
Maintaining results would be simpler if the Geolocation properties were excluded from unimportant tests and split into new tests where needed.
Comment 1 Steve Falkenburg 2010-01-22 15:19:53 PST
Created attachment 47233 [details]
patch
Comment 2 Darin Adler 2010-01-22 16:48:36 PST
Wait, the trybots are showing red. Please don’t land until you find out why.
Comment 3 Steve Falkenburg 2010-01-22 16:57:57 PST
The EWS bots don't run the layout tests, and this patch only changes files in the LayoutTests tree, so the red qt and gtk results can't be from this patch.
Comment 4 Steve Falkenburg 2010-01-22 17:08:21 PST
http://trac.webkit.org/changeset/53740