Summary: | Implement hardware acceleration of video on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Attachments: |
|
Description
Eric Carlson
2010-01-22 10:14:27 PST
Created attachment 47217 [details]
Proposed patch
Comment on attachment 47217 [details] Proposed patch > + (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the > + movie is not ready to render or the movie is in a media document. This isn't true anymore. > @@ -190,7 +199,7 @@ void MediaPlayerPrivate::pause() > return; > m_startedPlaying = false; > #if DRAW_FRAME_RATE > - m_timeStoppedPlaying = GetTickCount(); > + m_timeStoppedPlaying = WTF::currentTime(); You shouldn't need the "WTF::" here. r=me (In reply to comment #3) > (From update of attachment 47217 [details]) > > + (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): New, return true unless the > > + movie is not ready to render or the movie is in a media document. > > This isn't true anymore. > True. > > @@ -190,7 +199,7 @@ void MediaPlayerPrivate::pause() > > return; > > m_startedPlaying = false; > > #if DRAW_FRAME_RATE > > - m_timeStoppedPlaying = GetTickCount(); > > + m_timeStoppedPlaying = WTF::currentTime(); > > You shouldn't need the "WTF::" here. > MediaPlayerPrivate has a "currentTime" method. > r=me Thanks! With http://trac.webkit.org/changeset/53725 for good measure. |