| Summary: | Canvas: Exception erroneously thrown for drawImage() when image.complete=false | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kai Hendry <hendry> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | adele, commit-queue, kling, mdelaney7 | ||||
| Priority: | P2 | Keywords: | HTML5 | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://code.google.com/p/chromium/issues/detail?id=32712 | ||||||
| Attachments: |
|
||||||
|
Description
Kai Hendry
2010-01-21 12:42:20 PST
Both the site and WebKit are at fault here. The page is using $(document).ready() instead of $(window).load() - $d(document).ready() fires as soon as the DOM is ready instead of waiting for subresources (images in this case) to finish loading. However, since the image element passed to drawImage() has complete=false, nothing should be done (HTML5 4.8.11), so the exception is thrown in error. Patch coming in a moment. Created attachment 60021 [details] Proposed patch Implement correct behavior for drawImage() with incomplete image or video. Autotest included. Spec link: http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-drawimage For future visitors to this bug, the page at http://roulette.dabase.com/ has now been updated to use $(window).load() :-) Comment on attachment 60021 [details] Proposed patch Clearing flags on attachment: 60021 Committed r62273: <http://trac.webkit.org/changeset/62273> All reviewed patches have been landed. Closing bug. |