Summary: | webkit-patch should retry on invalid password | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joe Mason <joenotcharles> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Comment on attachment 47120 [details]
put bugzilla login in a loop
In general we prefer to add unit tests when changing code in webkitpy, but bugzilla.py is difficult to test currently.
Thanks for the patch.
Committed r53733: <http://trac.webkit.org/changeset/53733> |
Created attachment 47120 [details] put bugzilla login in a loop Making a typo in your password and having to restart the whole process is really annoying. webkit-patch should ask for credentials in a loop so that it automatically asks again on failure. (The user can always use Ctrl-C to break out.)