Bug 33955

Summary:

webkit-patch should retry on invalid password

Product:

WebKit

Reporter:

Joe Mason <joenotcharles>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
put bugzilla login in a loop	abarth: review+

Joe Mason

Reported 2010-01-21 08:23:09 PST

Created attachment 47120 [details] put bugzilla login in a loop Making a typo in your password and having to restart the whole process is really annoying. webkit-patch should ask for credentials in a loop so that it automatically asks again on failure. (The user can always use Ctrl-C to break out.)

Attachments
put bugzilla login in a loop (3.03 KB, patch) 2010-01-21 08:23 PST, Joe Mason	abarth: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2010-01-21 10:02:04 PST

Comment on attachment 47120 [details] put bugzilla login in a loop In general we prefer to add unit tests when changing code in webkitpy, but bugzilla.py is difficult to test currently. Thanks for the patch.

Adam Barth

Comment 2 2010-01-22 16:12:22 PST

Committed r53733: <http://trac.webkit.org/changeset/53733>

Note You need to log in before you can comment on or make changes to this bug.