Bug 33953

Summary:

[Android] Android lacks V8 equivalent of JavaStringJSC.h

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Bug Depends on:

Bug Blocks:

32154

Attachments:

Description	Flags
Patch	ariya.hidayat: review+

Description Steve Block 2010-01-21 08:15:37 PST

The JSC-specific implementation of JavaString was moved to JavaStringJSC.h in
http://trac.webkit.org/changeset/53449

Android requires a V8 implementation of JavaString

Comment 1 Steve Block 2010-01-29 03:35:54 PST

Created attachment 47698 [details]
Patch

Comment 2 Ariya Hidayat 2010-01-31 15:57:06 PST

Comment on attachment 47698 [details]
Patch


> +        const char* cs = getCharactersFromJStringInEnv(e, s);
> +        {
> +            m_utf8String = WebCore::CString(cs, size);
> +        }

Minor nitpick: since we don't need JSLock here, do we need to put that line in its own block?

Otherwise, LGTM.

Comment 3 Steve Block 2010-02-01 02:52:10 PST

> Minor nitpick: since we don't need JSLock here, do we need to put that line in
> its own block?
Fixed

Landed manually as http://trac.webkit.org/changeset/54132

Closing bug as resolved fixed.