Bug 33942

Summary: 3 tests for CSS are misplaced
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch darin: review+

Shinichiro Hamaji
Reported 2010-01-21 01:24:10 PST
The following 3 tests are in LayoutTests/css2.1. atrule_longest_match.html bogus-color-span.html css1_forward_compatible_parsing.html As this directory should be the copy of CSS2.1 testsuite, these files should be moved to another directory (probably LayoutTests/fast/css).
Attachments
Patch (165.06 KB, patch)
2010-01-21 01:29 PST, Shinichiro Hamaji 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-01-21 01:29:23 PST
Created attachment 47106 [details] Patch
Darin Adler
Comment 2 2010-01-21 09:27:31 PST
Comment on attachment 47106 [details] Patch r=me To make the hierarchy of LayoutTests more self explanatory we might want to add files to various directories to help explain their contents. They could be named README.txt or some other sensible name. Then the one for css2.1 could explain what that directory is. I think that would be even better than having external documentation about LayoutTests.
Shinichiro Hamaji
Comment 3 2010-01-21 17:42:27 PST
Committed r53664: <http://trac.webkit.org/changeset/53664>
Shinichiro Hamaji
Comment 4 2010-01-21 18:37:15 PST
> To make the hierarchy of LayoutTests more self explanatory we might want to add > files to various directories to help explain their contents. > > They could be named README.txt or some other sensible name. Then the one for > css2.1 could explain what that directory is. > > I think that would be even better than having external documentation about > LayoutTests. I really like this idea. I'm adding the first version of README.txt in the patch for Bug 17557.
Note You need to log in before you can comment on or make changes to this bug.