Bug 33935

Summary: Use xmlStrdup instead of strdup for consistency in Libxml2.
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Use xmlStrdup instead of strdup in Libxml2 none

Kwang Yul Seo
Reported 2010-01-20 18:51:48 PST
Use xmlStrdup instead of strdup for consistency. This is the first step to remove the direct use of strdup from WebKit. reinterpret_cast is required convert between xmlChar* and char* because xmlChar is typedef to unsigned char.
Attachments
Use xmlStrdup instead of strdup in Libxml2 (2.54 KB, patch)
2010-01-20 18:57 PST, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-01-20 18:57:58 PST
Created attachment 47091 [details] Use xmlStrdup instead of strdup in Libxml2
Alexey Proskuryakov
Comment 2 2010-01-20 21:03:24 PST
Comment on attachment 47091 [details] Use xmlStrdup instead of strdup in Libxml2 r=me
WebKit Commit Bot
Comment 3 2010-01-20 21:58:35 PST
Comment on attachment 47091 [details] Use xmlStrdup instead of strdup in Libxml2 Clearing flags on attachment: 47091 Committed r53604: <http://trac.webkit.org/changeset/53604>
WebKit Commit Bot
Comment 4 2010-01-20 21:58:41 PST
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 5 2019-02-06 09:03:25 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.