Bug 33932

Summary: [Chromium] Implement texSubImage2D taking WebGLArray
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, commit-queue, dglazkov, fishd, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Kenneth Russell
Reported 2010-01-20 18:27:30 PST
It seems that the texSubImage2D variant taking a WebGLArray as argument was not implemented in either https://bugs.webkit.org/show_bug.cgi?id=31562 or https://bugs.webkit.org/show_bug.cgi?id=33241 . This needs to be done.
Attachments
Patch (6.66 KB, patch)
2010-01-20 18:34 PST, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-01-20 18:34:32 PST
Created attachment 47090 [details] Patch Chromium-specific issue, but test case verified on WebKit as well.
Oliver Hunt
Comment 2 2010-01-20 18:40:14 PST
Comment on attachment 47090 [details] Patch r=me
Oliver Hunt
Comment 3 2010-01-20 19:04:45 PST
ken do you have commit bit yet?
Kenneth Russell
Comment 4 2010-01-21 10:05:18 PST
(In reply to comment #3) > ken do you have commit bit yet? Yes; I was waiting to see whether the bots would all clear the patch but it looks like a few are offline. Just cq+'d it.
WebKit Commit Bot
Comment 5 2010-01-21 13:01:47 PST
Comment on attachment 47090 [details] Patch Clearing flags on attachment: 47090 Committed r53640: <http://trac.webkit.org/changeset/53640>
WebKit Commit Bot
Comment 6 2010-01-21 13:02:00 PST
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 7 2010-01-21 23:26:27 PST
> Yes; I was waiting to see whether the bots would all clear the patch but it > looks like a few are offline. Just cq+'d it. The bots only run on patches that have review?. Once you r+ a patch, the bots ignore it.
Note You need to log in before you can comment on or make changes to this bug.