Bug 33918

Summary: MSAA: accSelect() is not implemented
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: AccessibilityAssignee: Jon Honeycutt <jhoneycutt>
Status: RESOLVED FIXED    
Severity: Normal CC: mattc
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch darin: review+, jhoneycutt: commit-queue-

Description Jon Honeycutt 2010-01-20 13:19:34 PST 
The IAccessible::accSelect() function is not implemented.

<rdar://problem/7436861>
Comment 1 Jon Honeycutt 2010-01-20 13:30:57 PST 
Created attachment 47060 [details]
patch
Comment 2 Darin Adler 2010-01-20 14:10:56 PST 
Comment on attachment 47060 [details]
patch

> +    // FIXME: Should implement SELFLAG_EXTENDSELECTION. For now, we just return
> +    // S_OK, matching Firefox.

Is that really better than returning E_INVALIDARG?
Comment 3 Jon Honeycutt 2010-01-20 14:33:22 PST 
(In reply to comment #2)
> (From update of attachment 47060 [details])
> > +    // FIXME: Should implement SELFLAG_EXTENDSELECTION. For now, we just return
> > +    // S_OK, matching Firefox.
> 
> Is that really better than returning E_INVALIDARG?

I'm not sure whether any clients use this flag, but I'd rather match Firefox's behavior.

Thanks for the review! Landed in r53567.
Comment 4 Jon Honeycutt 2011-03-31 16:27:50 PDT 
*** Bug 29124 has been marked as a duplicate of this bug. ***