Bug 33908

Summary: [Chromium] Skia "seatbelts" should be removed.
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Stephen White
Reported 2010-01-20 09:41:58 PST
[Chromium] Skia "seatbelts" should be removed.
Attachments
Patch (1.53 KB, patch)
2010-01-20 09:45 PST, Stephen White 		no flags
DetailsFormatted DiffDiff
Patch (1.59 KB, patch)
2010-01-20 10:00 PST, Stephen White 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2010-01-20 09:45:12 PST
Created attachment 47042 [details] Patch
Stephen White
Comment 2 2010-01-20 09:49:31 PST
ENSURE_VALUE_SAFETY_FOR_SKIA should be disabled, since we believe we've fixed the underlying Skia problems, and the seatbelts themselves also causing bugs (e.g., http://crbug.com/18630).
David Levin
Comment 3 2010-01-20 09:54:45 PST
Comment on attachment 47042 [details] Patch > Index: WebCore/ChangeLog > + Reviewed by NOBODY (OOPS!). > + > + Disable the "seatbelt" coordinate validation functions in the > + Skia graphics layer. We believe all the underlying bugs have > + been fixed, but just in case we're being overly optimistic, this > + leaves in the code for an easy revert. Please add a bug link here. > Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp > +// Diabling these checks (20/01/2010), since we think we've fixed all the Skia typo: Diabling
Stephen White
Comment 4 2010-01-20 10:00:37 PST
Created attachment 47044 [details] Patch
WebKit Commit Bot
Comment 5 2010-01-20 20:54:54 PST
Comment on attachment 47044 [details] Patch Clearing flags on attachment: 47044 Committed r53600: <http://trac.webkit.org/changeset/53600>
WebKit Commit Bot
Comment 6 2010-01-20 20:54:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.