Summary: | [Chromium] Skia "seatbelts" should be removed. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephen White <senorblanco> | ||||||
Component: | New Bugs | Assignee: | Stephen White <senorblanco> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Stephen White
2010-01-20 09:41:58 PST
Created attachment 47042 [details]
Patch
ENSURE_VALUE_SAFETY_FOR_SKIA should be disabled, since we believe we've fixed the underlying Skia problems, and the seatbelts themselves also causing bugs (e.g., http://crbug.com/18630). Comment on attachment 47042 [details] Patch > Index: WebCore/ChangeLog > + Reviewed by NOBODY (OOPS!). > + > + Disable the "seatbelt" coordinate validation functions in the > + Skia graphics layer. We believe all the underlying bugs have > + been fixed, but just in case we're being overly optimistic, this > + leaves in the code for an easy revert. Please add a bug link here. > Index: WebCore/platform/graphics/skia/GraphicsContextSkia.cpp > +// Diabling these checks (20/01/2010), since we think we've fixed all the Skia typo: Diabling Created attachment 47044 [details]
Patch
Comment on attachment 47044 [details] Patch Clearing flags on attachment: 47044 Committed r53600: <http://trac.webkit.org/changeset/53600> All reviewed patches have been landed. Closing bug. |