Bug 33904

Summary: Web Inspector: Add support for addMessage/clearMessages to SourceFrame2.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, joepeck, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed change. timothy: review+

Description Pavel Feldman 2010-01-20 08:28:55 PST 
Pretty much copied from SourceFrame + added corresponding TextEditor support.
Comment 1 Pavel Feldman 2010-01-20 08:34:31 PST 
Created attachment 47037 [details]
[PATCH] Proposed change.
Comment 2 Timothy Hatcher 2010-01-20 11:06:16 PST 
Comment on attachment 47037 [details]
[PATCH] Proposed change.

What does the "pack" in packAndRepaintAll mean?
Comment 3 Pavel Feldman 2010-01-25 03:01:45 PST 
(In reply to comment #2)
> (From update of attachment 47037 [details])
> What does the "pack" in packAndRepaintAll mean?

Div decorations are managed by the text editor clients. Sometimes decoration affects line height and we need to invalidate line offsets. That's what pack is for. I think I'll come up with the better name in a follow up change.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/WebCore.gypi
	M	WebCore/WebCore.vcproj/WebCore.vcproj
	M	WebCore/inspector/front-end/SourceFrame2.js
	M	WebCore/inspector/front-end/TextEditor.js
	M	WebCore/inspector/front-end/TextEditorHighlighter.js
	M	WebCore/inspector/front-end/WebKit.qrc
	M	WebCore/inspector/front-end/inspector.css
	M	WebCore/inspector/front-end/inspector.html
	A	WebCore/inspector/front-end/textEditor.css
Committed r53795