Bug 33898

Summary: [Android] Android lacks V8 equivalent of JavaClassJSC
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, eric, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Bug Depends on:    
Bug Blocks: 32154    
Attachments:
Description Flags
Patch ariya.hidayat: review+, steveblock: commit-queue-

Steve Block
Reported 2010-01-20 06:28:03 PST
The JSC-specific version of JavaClass was moved to JavaClassJSC in http://trac.webkit.org/changeset/53443 (ignore incorrect commit message) Android requires a V8 version of JavaClass
Attachments
Patch (7.99 KB, patch)
2010-01-29 04:14 PST, Steve Block 		ariya.hidayat: review+
steveblock: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-01-29 04:14:46 PST
Created attachment 47703 [details] Patch
Ariya Hidayat
Comment 2 2010-02-01 11:14:08 PST
Comment on attachment 47703 [details] Patch LGTM.
Steve Block
Comment 3 2010-02-01 16:12:09 PST
Comment on attachment 47703 [details] Patch cq- due to conflicts in Android.v8bindings.mk Will land manually
Eric Seidel (no email)
Comment 4 2010-02-01 16:12:43 PST
Attachment 47703 [details] was posted by a committer and has review+, assigning to Steve Block for commit.
Steve Block
Comment 5 2010-02-01 16:17:40 PST
Landed manually as http://trac.webkit.org/changeset/54169 Closing bug as resolved fixed.
Note You need to log in before you can comment on or make changes to this bug.