Bug 33898

Summary:

[Android] Android lacks V8 equivalent of JavaClassJSC

Product:

WebKit

Reporter:

Steve Block <steveblock>

Component:

WebCore Misc.

Assignee:

Steve Block <steveblock>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

android-webkit-unforking, eric, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Bug Depends on:

Bug Blocks:

32154

Attachments:

Description	Flags
Patch	ariya.hidayat: review+, steveblock: commit-queue-

Description Steve Block 2010-01-20 06:28:03 PST

The JSC-specific version of JavaClass was moved to JavaClassJSC in http://trac.webkit.org/changeset/53443 (ignore incorrect commit message)
Android requires a V8 version of JavaClass

Comment 1 Steve Block 2010-01-29 04:14:46 PST

Created attachment 47703 [details]
Patch

Comment 2 Ariya Hidayat 2010-02-01 11:14:08 PST

Comment on attachment 47703 [details]
Patch

LGTM.

Comment 3 Steve Block 2010-02-01 16:12:09 PST

Comment on attachment 47703 [details]
Patch

cq- due to conflicts in Android.v8bindings.mk
Will land manually

Comment 4 Eric Seidel (no email) 2010-02-01 16:12:43 PST

Attachment 47703 [details] was posted by a committer and has review+, assigning to Steve Block for commit.

Comment 5 Steve Block 2010-02-01 16:17:40 PST

Landed manually as http://trac.webkit.org/changeset/54169

Closing bug as resolved fixed.