Bug 33883

Summary: Feature defines are difficult to maintain on Windows builds
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Charles Wei <charles.wei>
Status: RESOLVED INVALID    
Severity: Normal CC: charles.wei
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Steve Falkenburg
Reported 2010-01-19 23:05:42 PST
Feature defines are difficult to maintain on Windows builds
Attachments
Patch (67.77 KB, patch)
2010-01-19 23:37 PST, Steve Falkenburg 		no flags
DetailsFormatted DiffDiff
Patch (26.06 KB, patch)
2012-06-27 00:23 PDT, Charles Wei 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-01-19 23:37:57 PST
Created attachment 46984 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-01-20 08:19:27 PST
Comment on attachment 46984 [details] Patch It might be good to make the comment in FeatureDefines.vsprops a little more explicit about how to add a new define (whether it is enabled or disabled). I.e., you have to add it to the PreprocessorDefinitions, and also add a UserMacro for it. r=me
Steve Falkenburg
Comment 3 2010-01-20 09:52:21 PST
http://trac.webkit.org/changeset/53554
Charles Wei
Comment 4 2012-06-27 00:23:49 PDT
Reopening to attach new patch.
Charles Wei
Comment 5 2012-06-27 00:23:54 PDT
Created attachment 149696 [details] Patch
Charles Wei
Comment 6 2012-07-01 02:18:48 PDT
Comment on attachment 149696 [details] Patch wrong place. This patch is for 88338 but put here by accident.
Charles Wei
Comment 7 2012-07-01 02:19:28 PDT
Mark it as invalid.
Note You need to log in before you can comment on or make changes to this bug.