Bug 33883

Summary:

Feature defines are difficult to maintain on Windows builds

Product:

WebKit

Reporter:

Steve Falkenburg <sfalken>

Component:

New Bugs

Assignee:

Charles Wei <charles.wei>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

charles.wei

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Steve Falkenburg 2010-01-19 23:05:42 PST

Feature defines are difficult to maintain on Windows builds

Comment 1 Steve Falkenburg 2010-01-19 23:37:57 PST

Created attachment 46984 [details]
Patch

Comment 2 Adam Roben (:aroben) 2010-01-20 08:19:27 PST

Comment on attachment 46984 [details]
Patch

It might be good to make the comment in FeatureDefines.vsprops a little more
explicit about how to add a new define (whether it is enabled or disabled).
I.e., you have to add it to the PreprocessorDefinitions, and also add a
UserMacro for it.

r=me

Comment 3 Steve Falkenburg 2010-01-20 09:52:21 PST

http://trac.webkit.org/changeset/53554

Comment 4 Charles Wei 2012-06-27 00:23:49 PDT

Reopening to attach new patch.

Comment 5 Charles Wei 2012-06-27 00:23:54 PDT

Created attachment 149696 [details]
Patch

Comment 6 Charles Wei 2012-07-01 02:18:48 PDT

Comment on attachment 149696 [details]
Patch

wrong place. This patch is for 88338 but put here by accident.

Comment 7 Charles Wei 2012-07-01 02:19:28 PDT

Mark it as invalid.