Summary: | Feature defines are difficult to maintain on Windows builds | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Falkenburg <sfalken> | ||||||
Component: | New Bugs | Assignee: | Charles Wei <charles.wei> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | charles.wei | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Steve Falkenburg
2010-01-19 23:05:42 PST
Created attachment 46984 [details]
Patch
Comment on attachment 46984 [details]
Patch
It might be good to make the comment in FeatureDefines.vsprops a little more
explicit about how to add a new define (whether it is enabled or disabled).
I.e., you have to add it to the PreprocessorDefinitions, and also add a
UserMacro for it.
r=me
Reopening to attach new patch. Created attachment 149696 [details]
Patch
Comment on attachment 149696 [details]
Patch
wrong place. This patch is for 88338 but put here by accident.
Mark it as invalid. |