Bug 33881

Summary: [Chromium] computePageRectsForFrame seems to be unnecessary
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: hayato, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch v1 none

Shinichiro Hamaji
Reported 2010-01-19 22:48:54 PST
It seems the pagination is done in PrintContext::computePageRects in WebCore/page/PrintContext is responsible for pagination on Chromium (note that this function is used in WebKit/chromium/src/WebFrameImpl.cpp via ChromePrintContext, which is a subclass of PrintContext). So, WebCore::computePageRectsForFrame in WebCore/page/FrameChromium.cpp, which is almost as same as PrintContext::computePageRects, would be unnecessary.
Attachments
Patch v1 (6.36 KB, patch)
2010-01-19 23:14 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-01-19 23:14:13 PST
Created attachment 46981 [details] Patch v1
Shinichiro Hamaji
Comment 2 2010-01-20 00:26:38 PST
Comment on attachment 46981 [details] Patch v1 Clearing flags on attachment: 46981 Committed r53527: <http://trac.webkit.org/changeset/53527>
Shinichiro Hamaji
Comment 3 2010-01-20 00:26:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.