|Summary:||[Chromium] computePageRectsForFrame seems to be unnecessary|
|Product:||WebKit||Reporter:||Shinichiro Hamaji <hamaji>|
|Component:||WebCore Misc.||Assignee:||Nobody <webkit-unassigned>|
|Version:||528+ (Nightly build)|
Description Shinichiro Hamaji 2010-01-19 22:48:54 PST
It seems the pagination is done in PrintContext::computePageRects in WebCore/page/PrintContext is responsible for pagination on Chromium (note that this function is used in WebKit/chromium/src/WebFrameImpl.cpp via ChromePrintContext, which is a subclass of PrintContext). So, WebCore::computePageRectsForFrame in WebCore/page/FrameChromium.cpp, which is almost as same as PrintContext::computePageRects, would be unnecessary.
Comment 2 Shinichiro Hamaji 2010-01-20 00:26:38 PST
Comment on attachment 46981 [details] Patch v1 Clearing flags on attachment: 46981 Committed r53527: <http://trac.webkit.org/changeset/53527>
Comment 3 Shinichiro Hamaji 2010-01-20 00:26:51 PST
All reviewed patches have been landed. Closing bug.