Bug 33866

Summary: Refactor JITStubs.cpp so that DEFINE_STUB_FUNCTION is only used once for each function
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, eric, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 27065    
Attachments:
Description Flags
proposed build fix for RVCT none

Laszlo Gombos
Reported 2010-01-19 13:57:21 PST
Place the guard USE(JSVALUE32_64) inside the body of the DEFINE_STUB_FUNCTION macro. This I think makes the code a bit more readable as it is clear that DEFINE_STUB_FUNCTION(int, op_eq) is needed regardless of the USE(JSVALUE32_64) test. This refactoring fixes a build break for the RVCT tool chain. For the RVCT toolchain (e.g. for Symbian) precompiler macros are not expanded before the code is passed to the assembler. This tool chain limitation and the corresponding workaround (simple perl script as pre-compiler) been documented as part of commit r52970. The current perl script does not take all the C precompiler macros into account, so it expands the DEFINE_STUB_FUNCTION macro twice for DEFINE_STUB_FUNCTION(int, op_eq).
Attachments
proposed build fix for RVCT (2.57 KB, patch)
2010-01-19 14:31 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-01-19 14:31:23 PST
Created attachment 46953 [details] proposed build fix for RVCT
Eric Seidel (no email)
Comment 2 2010-01-21 16:53:20 PST
Looks sane, but I'll CC the JIT people for a real review.
Maciej Stachowiak
Comment 3 2010-01-22 02:02:36 PST
Comment on attachment 46953 [details] proposed build fix for RVCT r=me
WebKit Commit Bot
Comment 4 2010-01-24 19:53:26 PST
Comment on attachment 46953 [details] proposed build fix for RVCT Clearing flags on attachment: 46953 Committed r53789: <http://trac.webkit.org/changeset/53789>
WebKit Commit Bot
Comment 5 2010-01-24 19:53:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.