Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns more info about where the result was found

• Component: WebKit API
• Status: RESOLVED FIXED

[John Sullivan]

WebHTMLRepresentation's searchForLabelsBeforeElement SPI function is used to search in the HTML visible content for any string from a given set of strings. It uses some heuristics for computing the result, but does not return any information about how the result was computed. It would be useful to clients of this function if they knew more about how the result was computed, in order to apply higher-level heuristics.

[John Sullivan]

Created attachment 46943 [details]
Patch that adds variant of searchForLabelsBeforeElement that includes two additional out parameters

[WebKit Review Bot]

Attachment 46943 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/win/WebHTMLRepresentation.cpp:199:  Extra space after ( in function call  [whitespace/parens] [4]
WebKit/win/WebHTMLRepresentation.h:93:  Extra space after ( in function call  [whitespace/parens] [4]
Total errors found: 2


If any of these errors are false positives, please file a bug against check-webkit-style.

[John Sullivan]

Created attachment 46944 [details]
Revised patch that replaces line-ending "( "s with "(" to make style checking script happy.

[John Sullivan]

Committed r53500: <http://trac.webkit.org/changeset/53500>

[Eric Seidel (no email)]

This broke the Tiger build:
http://build.webkit.org/builders/Tiger%20Intel%20Release/builds/7925/steps/compile-webkit/logs/stdio

[John Sullivan]

Fixed Tiger build in r53519.