Bug 33854

Summary: Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns more info about where the result was found
Product: WebKit Reporter: John Sullivan <sullivan>
Component: WebKit APIAssignee: John Sullivan <sullivan>
Status: RESOLVED FIXED    
Severity: Enhancement CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch that adds variant of searchForLabelsBeforeElement that includes two additional out parameters
none
Revised patch that replaces line-ending "( "s with "(" to make style checking script happy. darin: review+

John Sullivan
Reported 2010-01-19 11:40:39 PST
WebHTMLRepresentation's searchForLabelsBeforeElement SPI function is used to search in the HTML visible content for any string from a given set of strings. It uses some heuristics for computing the result, but does not return any information about how the result was computed. It would be useful to clients of this function if they knew more about how the result was computed, in order to apply higher-level heuristics.
Attachments
Patch that adds variant of searchForLabelsBeforeElement that includes two additional out parameters (24.68 KB, patch)
2010-01-19 13:24 PST, John Sullivan 		no flags
DetailsFormatted DiffDiff
Revised patch that replaces line-ending "( "s with "(" to make style checking script happy. (33.63 KB, patch)
2010-01-19 13:33 PST, John Sullivan 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Sullivan
Comment 1 2010-01-19 13:24:31 PST
Created attachment 46943 [details] Patch that adds variant of searchForLabelsBeforeElement that includes two additional out parameters
WebKit Review Bot
Comment 2 2010-01-19 13:25:44 PST
Attachment 46943 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/win/WebHTMLRepresentation.cpp:199: Extra space after ( in function call [whitespace/parens] [4] WebKit/win/WebHTMLRepresentation.h:93: Extra space after ( in function call [whitespace/parens] [4] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
John Sullivan
Comment 3 2010-01-19 13:33:02 PST
Created attachment 46944 [details] Revised patch that replaces line-ending "( "s with "(" to make style checking script happy.
John Sullivan
Comment 4 2010-01-19 15:26:16 PST
Committed r53500: <http://trac.webkit.org/changeset/53500>
Eric Seidel (no email)
Comment 5 2010-01-19 16:28:35 PST
This broke the Tiger build: http://build.webkit.org/builders/Tiger%20Intel%20Release/builds/7925/steps/compile-webkit/logs/stdio
John Sullivan
Comment 6 2010-01-19 20:09:35 PST
Fixed Tiger build in r53519.
Note You need to log in before you can comment on or make changes to this bug.