Bug 33853

Summary: InspectorTimelineAgent refactor to support reporting data when closing a record
Product: WebKit Reporter: jaimeyap
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, knorton, pfeldman, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
InspectorTimelineAgent refactor to support reporting data when closing a record none

Description jaimeyap 2010-01-19 11:35:43 PST
This patch (soon to be attached) refactors the TimelineRecordFactory and InspectorTimelineAgent to support reporting data when closing a record. Since ScriptObject has no get method for retrieving fields, eagerly installing a data object on the base record precluded us from adding any fields to it later on.

This patch also includes grabbing the start and end line number for parse HTML records as a reference use case for the above refactor.
Comment 1 jaimeyap 2010-01-19 11:49:59 PST
Created attachment 46932 [details]
InspectorTimelineAgent refactor to support reporting data when closing a record
Comment 2 WebKit Commit Bot 2010-01-19 13:49:38 PST
Comment on attachment 46932 [details]
InspectorTimelineAgent refactor to support reporting data when closing a record

Clearing flags on attachment: 46932

Committed r53488: <http://trac.webkit.org/changeset/53488>
Comment 3 WebKit Commit Bot 2010-01-19 13:49:45 PST
All reviewed patches have been landed.  Closing bug.