Summary: | jni_utility.[cpp|h] and jni_utility_private.[cpp|h] should be renamed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Steve Block <steveblock> | ||||
Component: | WebCore Misc. | Assignee: | Steve Block <steveblock> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | android-webkit-unforking, steveblock, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 33870 | ||||||
Bug Blocks: | 33712, 33901 | ||||||
Attachments: |
|
Description
Steve Block
2010-01-19 08:00:43 PST
Created attachment 46909 [details] Patch 1 for Bug 33843 Attachment 46909 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
Last 3072 characters of output:
ore/bridge/jni/JNIUtility.cpp:185: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/bridge/jni/JNIUtility.cpp:187: Missing space after , [whitespace/comma] [3]
WebCore/bridge/jni/JNIUtility.cpp:187: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/bridge/jni/JNIUtility.cpp:200: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebCore/bridge/jni/JNIUtility.cpp:199: Missing space before { [whitespace/braces] [5]
WebCore/bridge/jni/JNIUtility.cpp:243: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebCore/bridge/jni/JNIUtility.cpp:242: Missing space before { [whitespace/braces] [5]
WebCore/bridge/jni/JNIUtility.cpp:282: Extra space after ( in function call [whitespace/parens] [4]
WebCore/bridge/jni/JNIUtility.cpp:284: Declaration has space between type name and * in JavaVM *jvm [whitespace/declaration] [3]
WebCore/bridge/jni/JNIUtility.cpp:285: Declaration has space between type name and * in JNIEnv *env [whitespace/declaration] [3]
WebCore/bridge/jni/JNIUtility.cpp:288: Extra space before ( in function call [whitespace/parens] [4]
WebCore/bridge/jni/JNIUtility.cpp:289: Mismatching spaces inside () in if [whitespace/parens] [5]
WebCore/bridge/jni/JNIUtility.cpp:289: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/bridge/jni/JNIUtility.cpp:289: Use 0 instead of NULL. [readability/null] [5]
WebCore/bridge/jni/JNIUtility.cpp:291: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/bridge/jni/JNIUtility.cpp:291: Use 0 instead of NULL. [readability/null] [5]
WebCore/bridge/jni/JNIUtility.cpp:293: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
WebCore/bridge/jni/JNIUtility.cpp:293: Use 0 instead of NULL. [readability/null] [5]
WebCore/bridge/jni/JNIUtility.cpp:327: An else should appear on the same line as the preceding } [whitespace/newline] [4]
WebCore/bridge/jni/JNIUtility.cpp:328: This { should be at the end of the previous line [whitespace/braces] [4]
WebCore/bridge/jni/JNIUtility.cpp:332: Extra space before ( in function call [whitespace/parens] [4]
WebCore/bridge/jni/JNIUtility.cpp:337: An else should appear on the same line as the preceding } [whitespace/newline] [4]
WebCore/bridge/jni/JNIUtility.cpp:339: One line control clauses should not use braces. [whitespace/braces] [4]
WebCore/bridge/jni/JNIUtility.cpp:345: One space before end of line comments [whitespace/comments] [5]
Skipping input 'WebCore/bridge/jni/jsc/jni_utility_private.cpp': Can't open for reading
Total errors found: 85
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 46909 [details] did not pass style-queue: I'll fix the style in the moved code in a separate patch. Landed manually as http://trac.webkit.org/changeset/53497 Opened Bug 33870 to fix style in moved code. Style is now fixed Closing bug as resolved |