| Summary: | Web Inspector: Timeline panel's reset button problem | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, pfeldman, timothy | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Ilya Tikhonovsky
2010-01-18 23:52:30 PST
Created attachment 46897 [details]
The fix for reset button at Timeline panel
Fixes for:
Texts for dividers at overview pane;
Reset button functionality when Timeline was scrolled down;
Reset button functionality when working window has been changed;
Scroll position calculation when Timeline was scrolled down and working window was adjusted by overview pane.
Comment on attachment 46897 [details] The fix for reset button at Timeline panel > + if (recordsInWindow.length > startIndex) > + while (startIndex > 0 && recordsInWindow[startIndex].parent) > + startIndex--; > + else > + startIndex = recordsInWindow.length ? recordsInWindow.length - 1 : 0; > + I think that what has been happening here was fundamentally wrong. It probably regressed when I introduced expansion/collapsing. Row offset can no longer be calculated as number of record * row height. We now need to take expanded state into consideration. Created attachment 47017 [details]
The fix for reset button at Timeline panel
The fix for reset button at Timeline panel.
Fixes for:
Texts for dividers at overview pane;
Reset button functionality when Timeline was scrolled down;
Reset button functionality when working window has been changed;
Scroll position calculation when Timeline ±was scrolled down and working window
was adjusted by overview pane.
Obsolete adjustment of startIndex was removed.
Created attachment 47031 [details]
The fix for reset button at Timeline panel
The fix for reset button at Timeline panel.
Fixes for:
Texts for dividers at overview pane;
Reset button functionality when Timeline was scrolled down;
Reset button functionality when working window has been changed;
Scroll position calculation when Timeline was scrolled down and working window
was adjusted by overview pane.
Created attachment 47036 [details]
The fix for reset button at Timeline panel
The fix for reset button at Timeline panel
Fixes for:
Texts for dividers at overview pane;
Reset button functionality when Timeline was scrolled down;
Reset button functionality when working window has been changed;
Scroll position calculation when Timeline was scrolled down and working window
was adjusted by overview pane.
Comment on attachment 47036 [details] The fix for reset button at Timeline panel Clearing flags on attachment: 47036 Committed r53588: <http://trac.webkit.org/changeset/53588> All reviewed patches have been landed. Closing bug. |