Bug 33820

Summary: Inline functions that are hot in DOM manipulation
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Maciej Stachowiak
Reported 2010-01-18 17:52:04 PST
Inline functions that are hot in DOM manipulation
Attachments
Patch (27.91 KB, patch)
2010-01-18 18:14 PST, Maciej Stachowiak 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2010-01-18 18:14:46 PST
Created attachment 46873 [details] Patch
Adam Barth
Comment 2 2010-01-18 18:17:03 PST
Comment on attachment 46873 [details] Patch I approve this product and/or service.
Darin Adler
Comment 3 2010-01-19 09:04:06 PST
Comment on attachment 46873 [details] Patch > - Document(Frame*, bool isXHTML); > + Document(Frame*, bool isXHTML, bool isHTML); I'd much rather see an enum here instead of two bools.
Maciej Stachowiak
Comment 4 2010-01-19 18:25:40 PST
Committed r53514: <http://trac.webkit.org/changeset/53514>
Eric Seidel (no email)
Comment 5 2010-01-19 23:34:09 PST
A webgl failure seemed to start with this checkin: http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r53517%20(9580)/fast/canvas/webgl/texImage2DImageDataTest-pretty-diff.html The first failure started between r53514 and r53517 inclusive.
Note You need to log in before you can comment on or make changes to this bug.