Bug 33794

Summary: Web Inspector: Speed-up Timeline panel scrolling (second iteration).
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
The fixes for Timeline panel scrolling speed
pfeldman: review-
Next iteration. Calculator object was a bit redesigned. none

Ilya Tikhonovsky
Reported 2010-01-18 05:15:24 PST
Timeline's panel scrolling speed can be 2 times faster.
Attachments
The fixes for Timeline panel scrolling speed (6.09 KB, patch)
2010-01-18 06:12 PST, Ilya Tikhonovsky 		pfeldman: review-
DetailsFormatted DiffDiff
Next iteration. Calculator object was a bit redesigned. (7.50 KB, patch)
2010-01-18 07:45 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-01-18 06:12:25 PST
Created attachment 46814 [details] The fixes for Timeline panel scrolling speed
Pavel Feldman
Comment 2 2010-01-18 06:31:17 PST
Comment on attachment 46814 [details] The fixes for Timeline panel scrolling speed > + this._graphRows = document.createElement("div"); We typically call elements someElement. Maybe kill it? > - var start = (record.startTime - this.minimumBoundary) / this.boundarySpan * 100; > - var end = (record.endTime - this.minimumBoundary) / this.boundarySpan * 100; > + var start = (record.startTime - this._context.minB) / this._context.bSpan * 100; this._context.minimumBoundary. Btw, this calculator is supposed to cache min and max boundaries, so it is not clear why you are gaining some win out of it. Maybe cache is broken? Or typeof ... === "number" works slowly? Should we try using -1 as an uninitialized value then?
Ilya Tikhonovsky
Comment 3 2010-01-18 07:45:59 PST
Created attachment 46824 [details] Next iteration. Calculator object was a bit redesigned.
WebKit Commit Bot
Comment 4 2010-01-18 10:31:30 PST
Comment on attachment 46824 [details] Next iteration. Calculator object was a bit redesigned. Clearing flags on attachment: 46824 Committed r53413: <http://trac.webkit.org/changeset/53413>
WebKit Commit Bot
Comment 5 2010-01-18 10:31:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.