Summary: | Web Inspector: Speed-up Timeline panel scrolling (second iteration). | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, pfeldman | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2010-01-18 05:15:24 PST
Created attachment 46814 [details]
The fixes for Timeline panel scrolling speed
Comment on attachment 46814 [details] The fixes for Timeline panel scrolling speed > + this._graphRows = document.createElement("div"); We typically call elements someElement. Maybe kill it? > - var start = (record.startTime - this.minimumBoundary) / this.boundarySpan * 100; > - var end = (record.endTime - this.minimumBoundary) / this.boundarySpan * 100; > + var start = (record.startTime - this._context.minB) / this._context.bSpan * 100; this._context.minimumBoundary. Btw, this calculator is supposed to cache min and max boundaries, so it is not clear why you are gaining some win out of it. Maybe cache is broken? Or typeof ... === "number" works slowly? Should we try using -1 as an uninitialized value then? Created attachment 46824 [details]
Next iteration. Calculator object was a bit redesigned.
Comment on attachment 46824 [details] Next iteration. Calculator object was a bit redesigned. Clearing flags on attachment: 46824 Committed r53413: <http://trac.webkit.org/changeset/53413> All reviewed patches have been landed. Closing bug. |