Summary: | Add constants for more XML strings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2010-01-18 01:16:21 PST
Created attachment 46803 [details]
proposed patch
Attachment 46803 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/dom/Node.cpp:1868: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
WebCore/dom/Node.cpp:1923: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 2
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 46803 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/195756 > Build output: http://webkit-commit-queue.appspot.com/results/195756
It's empty.
Committed revision 53429. |