Bug 33787

Summary: Add constants for more XML strings
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2010-01-18 01:16:21 PST
From bug 33752: I suggest we add the strings "xmlns", "http://www.w3.org/2000/xmlns/", and "xml" all to XMLNames.h alongside xmlNamespaceURI and use named constants instead of literal strings.
Attachments
proposed patch (25.10 KB, patch)
2010-01-18 01:39 PST, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-01-18 01:39:10 PST
Created attachment 46803 [details] proposed patch
WebKit Review Bot
Comment 2 2010-01-18 01:46:50 PST
Attachment 46803 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/dom/Node.cpp:1868: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebCore/dom/Node.cpp:1923: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2010-01-18 02:11:10 PST
Attachment 46803 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/195756
Alexey Proskuryakov
Comment 4 2010-01-18 08:27:21 PST
> Build output: http://webkit-commit-queue.appspot.com/results/195756 It's empty.
Alexey Proskuryakov
Comment 5 2010-01-18 14:06:51 PST
Committed revision 53429.
Note You need to log in before you can comment on or make changes to this bug.